Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 跳转时间超出总时长 #272

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: 跳转时间超出总时长 #272

merged 1 commit into from
Jun 25, 2024

Conversation

tangying1027
Copy link
Contributor

No description provided.

@tangying1027 tangying1027 requested a review from zengyue June 21, 2024 10:24
@tangying1027 tangying1027 force-pushed the fix-goto branch 3 times, most recently from 7d4c9d5 to 7fb7e0a Compare June 24, 2024 08:47
time -= cur.time; // 计算剩余时间
} else {
break;
}
}

// 超出了总时长
const threshold = 0.0001;
if (target === animUnits.length && Math.abs(time - threshold) > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里后面的条件应该是 >= 。。

@zengyue zengyue merged commit 9128cfa into beta-5.x Jun 25, 2024
1 of 5 checks passed
@zengyue zengyue deleted the fix-goto branch June 25, 2024 03:45
zengyue pushed a commit that referenced this pull request Jun 28, 2024
* Feat:player (#264)

* feat: 播放暂停结束功能

* fix: 去掉render Children内的逻辑

* fix: 组件动画参数逻辑调整

* fix: lint

* chore:调整duration逻辑

* feat: 发布脚本

---------

Co-authored-by: xuying.xu <[email protected]>

* feat:增加跳转&速度控制 (#267)

* feat: 增加跳转

* feat: speed

---------

Co-authored-by: xuying.xu <[email protected]>

* fix:snapshot为上一帧执行完动画的shape (#269)

Co-authored-by: xuying.xu <[email protected]>

* feat: clip 动画增加执行完不删除clip (#271)

* fix: animation set time 0

* feat: clip增加deleteAfterComplete属性

---------

Co-authored-by: xuying.xu <[email protected]>

* fix: 跳转超出总时长 (#272)

Co-authored-by: xuying.xu <[email protected]>

* fix: 初始time不生效 (#273)

Co-authored-by: xuying.xu <[email protected]>

---------

Co-authored-by: xuying.xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants