Skip to content

Checklist for PR reviewer

Esora edited this page Oct 25, 2021 · 1 revision

As a PR reviewer, you are required to ensure ALL the following items are checked.

Before starting a review

The PR template is filled correctly with easy understanding words. Screenshots are attached if UI changes involved. The PR is squashed (1 commit per feature/fix/...) and rebased against the develop branch. The commit messages are following the guideline and are informative as the release note. The PR links to the corresponding issue with "closes #xyz", if it fixes an issue. If new features are introduced, the tests should also be included.

Before merge

The code addresses all your comments. The PR is rebased and squashed. No personal information and configuration are leaked into the commits.

Clone this wiki locally