Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grafana e2e test #646

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix Grafana e2e test #646

merged 1 commit into from
Dec 12, 2023

Conversation

yuntanghsu
Copy link
Contributor

@yuntanghsu yuntanghsu commented Dec 8, 2023

In this PR we fix e2e test. We only apply these 10 np/anp in the flow-visibility e2e test:

test-flow-aggregator-networkpolicy-ingress-allow
test-flow-aggregator-networkpolicy-egress-allow
test-flow-aggregator-anp-ingress-reject
test-flow-aggregator-anp-ingress-drop
test-flow-aggregator-anp-egress-reject
test-flow-aggregator-anp-egress-drop
test-flow-aggregator-np-ingress-deny
test-flow-aggregator-np-egress-deny
test-flow-aggregator-antrea-networkpolicy-egress
test-flow-aggregator-antrea-networkpolicy-ingress

The e2e test keeps failing because it expects to see 16 networkpolicies in the home page instead of 10 networkpolicies.

Note:
This test has been passed for the previous 1 year. For some reason (unknown), we were expecting 16 web policies on the homepage.

Screenshot 2023-12-11 at 4 04 03 PM
Screenshot 2023-12-11 at 4 03 52 PM

Signed-off-by: Yun-Tang Hsu <[email protected]>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #646 (ab224c3) into main (4150c50) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #646   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files          40       40           
  Lines        5253     5253           
=======================================
  Hits         3704     3704           
  Misses       1372     1372           
  Partials      177      177           
Flag Coverage Δ *Carryforward flag
kind-e2e-tests 62.34% <ø> (-0.15%) ⬇️
kind-multi-cluster-e2e-tests 43.17% <ø> (ø)
python-coverage 55.75% <ø> (ø) Carriedforward from 4150c50
unit-tests 70.25% <ø> (+0.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

@yuntanghsu
Copy link
Contributor Author

/theia-test-e2e

Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuntanghsu yuntanghsu merged commit b5d6e55 into antrea-io:main Dec 12, 2023
49 checks passed
@yuntanghsu yuntanghsu deleted the grafana_e2e branch December 13, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants