Removed the sendMessageWithTimeout and moved the timeout logic #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the libopenflow library. Signed-off-by: Ashish Varma <[email protected]>
wenyingd
reviewed
May 8, 2023
There was a problem hiding this comment.
Please update go.mod file to leverage this change antrea-io/libOpenflow#31 after it is merged.
BTW, you also need to update the VERSION file
| @@ -377,11 +378,18 @@ func (c *Controller) Parse(b []byte) (message util.Message, err error) { | |||
| return | |||
| } | |||
|
|
|||
| func sendMessageWithTimeout(stream *util.MessageStream, msg util.Message) error { | |||
| func sendMessage(stream *util.MessageStream, msg util.Message) error { | |||
There was a problem hiding this comment.
You may also need to update "Send" function in ofSwitch.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the sendMessageWithTimeout and moved the timeout logic to the libopenflow library.