Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nsh encap and decap #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

zhenglinan
Copy link

support nsh encap and decap
@tnqn
Signed-off-by: zhenglinan [email protected]

@tnqn tnqn requested a review from wenyingd August 15, 2022 14:51
@tnqn
Copy link
Member

tnqn commented Aug 15, 2022

@zhenglinan thanks for the PR.
@wenyingd could you take a look?

type NXEncapsulate struct {
HeaderSize uint16
HeaderType uint32
Property []openflow15.PropTLV

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename as Properties?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -57,6 +57,8 @@ const (
ActTypeSetField = "setField"
ActTypeCopyField = "copyField"
ActTypeMeter = "meter"
ActTypeEncapsulate = "encap"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A similar question on the name to this one antrea-io/libOpenflow#25 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not only for nsh,it is for ethernet、nsh、mpls and mplstc

@wenyingd
Copy link

Please update file VERSION, and go.mod/go.sum to import the changes in libOpenflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants