remove user rules in Azure that are in Nephe priority range #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenmo3
force-pushed
the
remove-user-rule
branch
from
f1df862
to
cc7b4d7
Compare
shenmo3
force-pushed
the
remove-user-rule
branch
from
cc7b4d7
to
1ecbc4e
Compare
reachjainrahul
force-pushed
the
remove-user-rule
branch
from
ee920a6
to
7c1b077
Compare
|
/nephe-test-e2e-agentless |
reachjainrahul
force-pushed
the
remove-user-rule
branch
from
7c1b077
to
ccb254d
Compare
Signed-off-by: Alexander Liu <[email protected]>
shenmo3
force-pushed
the
remove-user-rule
branch
2 times, most recently
from
b56bcfe
to
538c9e3
Compare
| @@ -15,14 +15,14 @@ | |||
| package networkpolicy | |||
|
|
|||
| import ( | |||
| runtimev1alpha1 "antrea.io/nephe/apis/runtime/v1alpha1" | |||
| @@ -45,7 +45,10 @@ func (s *securityGroupImpl) syncImpl(csg cloudSecurityGroup, syncContent *cloudr | |||
| if len(syncMembers) > 0 && syncMembers[0].Type == cloudresource.CloudResourceTypeNIC { | |||
| cachedMembers, _ = r.getNICsOfCloudResources(s.members) | |||
| } | |||
| if compareCloudResources(cachedMembers, syncMembers) { | |||
| if !membershipOnly && len(syncContent.MembersWithOtherSGAttached) > 0 { | |||
There was a problem hiding this comment.
remove dead code at line 57
Signed-off-by: Alexander Liu <[email protected]>
|
/nephe-test-e2e-agentless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, Nephe preserves all user custom rules in Azure, even if they fall within the priority range designated for Nephe (2000-4096). This approach can lead to issues and confusions with rule priority computation. To address this, this PR introduces a restriction on Azure user custom rules, removing user custom rules within the Nephe priority range.
Changes