Update NodeLatencyMonitor unit tests #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoninbas
commented
Oct 2, 2024
antoninbas
commented
- Add missing crdInformerFactory.Start call for TestNodeAddUpdateDelete to avoid cache sync error logs.
- Add extra logging for TestUpdateMonitorPingInterval, which has been failing infrequently in CI. I cannot figure out the reason for the failures, nor have I been able to reproduce it locally, so adding some logs may help.
* Add missing crdInformerFactory.Start call for TestNodeAddUpdateDelete to avoid cache sync error logs. * Add extra logging for TestUpdateMonitorPingInterval, which has been failing infrequently in CI. I cannot figure out the reason for the failures, nor have I been able to reproduce it locally, so adding some logs may help. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
commented
Oct 2, 2024
| @@ -452,6 +452,7 @@ func (m *NodeLatencyMonitor) monitorLoop(stopCh <-chan struct{}) { | |||
| case <-stopCh: | |||
| return | |||
| case latencyConfig := <-m.latencyConfigChanged: | |||
| klog.InfoS("NodeLatencyMonitor configuration has changed", "enabled", latencyConfig.Enable, "interval", latencyConfig.Interval) | |||
There was a problem hiding this comment.
this is a good log to have, regardless of the other changes in this PR
antoninbas
added
the
area/test
tnqn
approved these changes
Oct 8, 2024
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.