[FlowAggregator] Add templateRefreshTimeout configuration #6699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
added
area/flow-visibility/aggregator
Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector. We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
fa-add-templateRefreshTimeout-configuration
branch
from
346e01d
to
f57b7c0
Compare
heanlan
reviewed
Oct 9, 2024
|
Thanks @heanlan, I can fix it when I squash and merge. |
|
/test-kind-all |
heanlan
approved these changes
Oct 9, 2024
|
/test-kind-all |
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used to configure the template retransmission interval when using the UDP protocol to export records to an IPFIX collector.
We also ensure that the default value is 600s, not 1800s, which is the value specified in RFC 6728. We do the same thing for the Agent Exporter, but this time by letting the go-ipfix library decide the value (we set it to 0 in ExporterInput to request the default). This is important because the templateRefreshTimeout config in the Agent's exporter and the templateTTL in teh Aggregator's collector must "match" (templateTTL = 3 x templateRefreshTimeout), and so it is better to let go-ipfix pick the right values for both.