Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unsafe.Slice with memory copying to avoid potential fault memory issue #6665

Closed
wants to merge 2 commits into from
Closed

Replace unsafe.Slice with memory copying to avoid potential fault memory issue #6665

wants to merge 2 commits into from

Conversation

XinShuYang
Copy link
Contributor

  • Refactored ListIPForwardRows to copy IP forwarding table rows.
  • Removed unsafe.Slice and replaced with pointer dereferencing and copying.
  • This change addresses a potential fault memory issue when iterating through the IP forwarding table.

@XinShuYang
Add docker credentials to windows CI to avoid rate limit issue
e3309c9 
Signed-off-by: Shuyang Xin <[email protected]>
@XinShuYang
Replace unsafe.Slice with memory copying to avoid potential fault mem…
870d43b 
…ory issue

* Refactored ListIPForwardRows to copy IP forwarding table rows.
* Removed unsafe.Slice and replaced with manual pointer dereferencing and copying.
* This change addresses a potential fault memory issue when iterating through the IP forwarding table.

Signed-off-by: Shuyang Xin <[email protected]>
@XinShuYang
Copy link
Contributor Author

/test-windows-all

@antoninbas antoninbas mentioned this pull request Sep 12, 2024
Merged
@luolanzone
Copy link
Contributor

Can this be closed? @XinShuYang

@XinShuYang
Copy link
Contributor Author

Can this be closed? @XinShuYang

Yes, thanks for the reminder.

@XinShuYang XinShuYang closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XinShuYang @luolanzone