Automated cherry pick of #6366: Avoid generating defunct process when starting Suricata #6375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When antrea-agent starts Suricata instance with the following command: ``` suricata -c /etc/suricata/suricata.yaml --af-packet -D -l /var/log/antrea/networkpolicy/l7engine/ ``` The method `Run()` of `exec.Cmd` should be used instead of `Start()` to avoid generating a zombie process. The above command will exit after starting the process of Suricata instance in the background, so using `Run()` ensures that the command's resources are properly released and no defunct process remains. Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
added
the
kind/cherry-pick
tnqn
approved these changes
May 28, 2024
hongliangl
deleted the
automated-cherry-pick-of-#6366-upstream-release-1.15
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #6366 on release-1.15.
#6366: Avoid generating defunct process when starting Suricata
For details on the cherry pick process, see the cherry pick requests page.