Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick of #5592: Remove redundant log in fillPodInfo/fillServiceInfo, #5731: Use labels to enhance records filtering in FA e2e tests, #5770: Improve flow-visibility e2e test on upstream release 1.14 #5900

Conversation

yuntanghsu
Copy link
Contributor

Cherry pick of #5592 #5731 #5770 on release-1.14.

#5592: Remove redundant log in fillPodInfo/fillServiceInfo
#5731: Use labels to enhance records filtering in FA e2e tests
#5770: Improve flow-visibility e2e test

…onnection store. (antrea-io#5592)

1. Remove redundant logs in fillPodInfo/fillServiceInfo to avoid Flow
   Exporter from flooding logs.
2. Add Mark field for deny connections. We were missing this field
   previously, resulting in trying to fill service information for
   non-service IPs.
3. Update the DestinationServiceAddress for deny connections when we can
   find this information in PacketIn.
4. Update e2e/unit tests to verify that the Service-relateds field are
   filled correctly.

Fixes antrea-io#5573

Signed-off-by: Yun-Tang Hsu <[email protected]>
In this commit, we:

1. Add a label to Perftest Pods before initiating traffic in each subtest to filter records in both the IPFIX collector Pod and the ClickHouse.
2. Remove the --since-time flag used during log retrieval from the IPFIX collector Pod in the e2e test.
3. Stop relying on timestamps for record filtering due to potential time discrepancies between the testbed and Kubernetes nodes, which might hinder the retrieval of desired records.

Signed-off-by: Yun-Tang Hsu <[email protected]>
1. Changed the order in which we append expired records before exporting
   them from our exporter. For inter-Node traffic with egress/ingress NP
   with action drop, we will receive records from both PacketIn and the
   conntrack table. For the egress case, we need to ensure that the
   PacketIn record arrives at the FA first, or we will be stuck waiting
   for correlation.

2. Add checks to verify that records can successfully be sent by the
   Flow Exporter before sending traffic in e2e tests.

3. Add labels to External subtest to filter useless logs from the IPFIX
   collector Pod.

4. Confirm the correct addition of a label to a specific Pod after
   updating the Pod.

5. Remove the octetDeltaCount check and, instead, filter out all records
   with octetDeltaCount=0 when retrieving records from the IPFIX
   collector Pod and ClickHouse.

6. Use new version of go-ipfix test collector. The new collector no
    longer prints all received records. Instead records are saved
    in-memory, and can be queried over HTTP. The list of records can
    also be reset with an HTTP call. In this way, we can drastically
    reduce the time to retrieve records in tests.

Signed-off-by: Yun-Tang Hsu <[email protected]>
@yuntanghsu yuntanghsu changed the title Cherry pick of #5592 #5731 #5770 upstream release 1.14 Cherry pick of #5592: Remove redundant log in fillPodInfo/fillServiceInfo, #5731: Use labels to enhance records filtering in FA e2e tests, #5770: Improve flow-visibility e2e test to upstream release 1.14 Jan 22, 2024
@yuntanghsu yuntanghsu changed the title Cherry pick of #5592: Remove redundant log in fillPodInfo/fillServiceInfo, #5731: Use labels to enhance records filtering in FA e2e tests, #5770: Improve flow-visibility e2e test to upstream release 1.14 Cherry pick of #5592: Remove redundant log in fillPodInfo/fillServiceInfo, #5731: Use labels to enhance records filtering in FA e2e tests, #5770: Improve flow-visibility e2e test on upstream release 1.14 Jan 22, 2024
@antoninbas antoninbas added the kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release label Jan 22, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-all

@antoninbas antoninbas merged commit 25acf6c into antrea-io:release-1.14 Jan 23, 2024
83 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cherry-pick Categorizes issue or PR as related to the cherry-pick of a bug fix from the main branch to a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants