Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recommended 'inputs' context in github workflows #5826

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

luolanzone
Copy link
Contributor

@luolanzone luolanzone commented Dec 26, 2023

Use recommended 'inputs' context in github workflows to fix the if condition check.

@luolanzone luolanzone added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2023
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommended approach nowadays is to use the "unified" inputs context. See https://docs.github.com/en/actions/learn-github-actions/contexts#inputs-context. It replaces github.event.inputs, where all the input values were actually strings.

So if: ${{ github.event.inputs.push }} becomes if: ${{ inputs.push }}

I see that conformance.yml already uses the inputs context, we just need to update docker_update_base_windows.yml and trivy_scan.yml.

@luolanzone luolanzone changed the title Fix Windows workflow boolean check issue Use recommended 'inputs' context in github workflows Jan 8, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas merged commit d397d59 into antrea-io:main Jan 8, 2024
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants