Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the code for configuring Windows networking into dedicated package #5159

Merged
merged 3 commits into from
May 21, 2024
Merged

Reorganize the code for configuring Windows networking into dedicated package #5159

merged 3 commits into from
May 21, 2024

Commits on May 11, 2024

  1. Reorganize the code for configuring Windows networking into dedicated… 

    … package

This commits reorganizes Windows-related code for configuring Windows networking
into dedicated package `pkg/agent/util/winnet`, enhancing clarity and making it
easier for developers to locate and understand the Windows-specific functionality.
Besides, an interface implemented by the Windows-specific networking utility
functions is added to the package, facilitating easier testing and enhancing code
maintainability.

Furthermore, additional unit tests are added for the file
`pkg/agent/route/route_windows.go`, based on the testing code in the packages.
This enhances the code coverage of file `route_windows.go`.

Signed-off-by: Hongliang Liu <[email protected]>
    @hongliangl
    hongliangl committed May 11, 2024
    Configuration menu
    Copy the full SHA
    9b1db21 View commit details
    Browse the repository at this point in the history

  2. Updates for review comments 

    Signed-off-by: Hongliang Liu <[email protected]>
    @hongliangl
    hongliangl committed May 11, 2024
    Configuration menu
    Copy the full SHA
    3a157cf View commit details
    Browse the repository at this point in the history

  3. Updates 

    Signed-off-by: Hongliang Liu <[email protected]>
    @hongliangl
    hongliangl committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0619ea0 View commit details
    Browse the repository at this point in the history