Replace unsafe.Slice with memory copying to avoid potential fault mem…

…ory issue * Refactored ListIPForwardRows to copy IP forwarding table rows. * Removed unsafe.Slice and replaced with manual pointer dereferencing and copying. * This change addresses a potential fault memory issue when iterating through the IP forwarding table. Signed-off-by: Shuyang Xin <[email protected]>
antrea-io · Sep 12, 2024 · eab0b6c · eab0b6c
1 parent b3936b1
commit eab0b6c
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/pkg/agent/util/syscall/syscall_windows.go b/pkg/agent/util/syscall/syscall_windows.go
@@ -368,7 +368,16 @@ func (n *netIO) ListIPForwardRows(family uint16) ([]MibIPForwardRow, error) {
 	if err != nil {
 		return nil, os.NewSyscallError("iphlpapi.GetIpForwardTable", err)
 	}
-	return unsafe.Slice(&table.Table[0], table.NumEntries), nil
+	rows := make([]*MibIPForwardRow, table.NumEntries, table.NumEntries)
+
+	pFirstRow := uintptr(unsafe.Pointer(&table.Table[0]))
+	rowSize := unsafe.Sizeof(table.Table[0])
+
+	for i := uint32(0); i < table.NumEntries; i++ {
+		row := *(*MibIPForwardRow)(unsafe.Pointer(pFirstRow + rowSize*uintptr(i)))
+		rows[i] = &row
+	}
+	return rows, nil
 }
 
 func NewIPForwardRow() *MibIPForwardRow {