-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plsql] Added Antlr4ng, Cpp, Dart, Go ports. Dart-specific .g4 files removed. #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"postinclude" does not work for any targets other than hardwired C++. We need "includes" for Antlr4ng. Change grammar to avoid symbol conflicts with C++ runtime headers.
* We must compile with /bigobj. The generated parser is huge. This may not work on linux.
kaby76
changed the title
[plsql] Add other ports for grammar.
[plsql] Add Antlr4ng, Cpp, Dart, Go ports.
Dec 19, 2024
…x "expressions" symbol conflict for Dart port.
…Re-add and remasster.
kaby76
changed the title
[plsql] Add Antlr4ng, Cpp, Dart, Go ports.
[plsql] Added Antlr4ng, Cpp, Dart, Go ports. The .g4s forked for Dart were removed.
Dec 20, 2024
kaby76
changed the title
[plsql] Added Antlr4ng, Cpp, Dart, Go ports. The .g4s forked for Dart were removed.
[plsql] Added Antlr4ng, Cpp, Dart, Go ports. Dart-specific .g4 files removed.
Dec 21, 2024
For ignore file, we add both examples directories so that either test doesn't copy test files.
@kaby76 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added a bunch of ports for the plsql grammar. I cleaned up some of the target-specific code, reorganized the tests. This is so I can do performance testing, which is also included in this PR.
options { superClass=foobar; }
, the generated parser and lexer classes have the necessary "imports" for the base class, so that no additional syntax is needed. Requiring per-target syntax include is a complete mess, introducing yet another way to break the use of the grammar across targets.examples/
, and a select number of other tests inmore/
.