Fix three warnings (Wunused-parameter, Wsign-compare, Wdeprecated-declarations) and a typo. #4488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Turrado Camblor <[email protected]>
UnbufferedCharStream.cpp: fixed warning: comparison of integers of different signs: 'value_type' (aka 'char32_t') and 'int_type' (aka 'int') [-Wsign-compare]. Vocabulary.cpp: fixed warning: ‘antlr4::dfa::Vocabulary::EMPTY_VOCABULARY’ is deprecated: Use the default constructor of Vocabulary instead. [-Wdeprecated-declarations]. Signed-off-by: rturrado <[email protected]>
rturrado
changed the title
jmairboeck
reviewed
Jul 9, 2024
| @@ -155,7 +155,7 @@ void XPathLexer::action(RuleContext *context, size_t ruleIndex, size_t actionInd | |||
| } | |||
| } | |||
|
|
|||
| void XPathLexer::IDAction(antlr4::RuleContext *context, size_t actionIndex) { | |||
| void XPathLexer::IDAction(antlr4::RuleContext */*context*/, size_t actionIndex) { | |||
There was a problem hiding this comment.
This file is generated. I added a comment to #4171 (which is about a similar issue) to fix the generator template instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just commented out the unused parameter as I've seen you do in other parts of the code, with
/*variableName*/.