PLEASE SEND PRS TO linenoise.cpp

[ericcurtin]

https://github.com/ericcurtin/linenoise.cpp

[andreca]

Hello @ericcurtin, are you the new maintainer?

[ericcurtin]

I wrote a new C++ version of it because I want to make it a little safer (and I also want to build it with C++ compilers, plan on using it for llama.cpp). I offer to maintain this fork, feel free to send any patches that you may have intended to send to the C version.

[ericcurtin]

@mzhang28 I'm surprised this got a thumbs down, nothing has been merged here in 11 months, it's essentially unmaintained, I'm offering to change that.

[yhirose]

@ericcurtin does your version have a UTF-8 string support which is lacking in the original linenoise? If so, I am interested in yours. :)

Here is my pull request to add UTF-8 support to the original linenoise. (Currently, it supports the latest Unicode 16.0.)
https://github.com/antirez/linenoise/pull/187/files
#25

[ericcurtin]

@yhirose if you open a PR for that in linenoise.cpp , write some unit tests, we can get it reviewed and merged.

[yhirose]

Great! I'll try to migrate my patch to linenoise.cpp and send the PR to your project. :)