Update Pomodoro timer logic to use fixed values for mode transitions

anthonyhuang07 · Nov 17, 2024 · 507fc83 · 507fc83
1 parent 4fb7d5d
commit 507fc83
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/scripts/main.js b/src/scripts/main.js
@@ -128,7 +128,7 @@ function startTimer() {
             currentTime = -1;
             playSoundTimer();
             clearInterval(timer);
-            if (mode === 1 && numOfPomodoros !== (pomNo.value - 1)) { // if was in Pomodoro Mode (go to Short)
+            if (mode === 1 && numOfPomodoros !== 3) { // if was in Pomodoro Mode (go to Short)
                 mode = 2;
                 countdown.innerHTML = formatTime(shortTime);
                 document.title = formatTime(shortTime) + " - PomodoPro";
@@ -139,7 +139,7 @@ function startTimer() {
                 startButton.style.display = "block";
                 stopButton.style.display = "none";
             }
-            else if (mode === 2 && numOfPomodoros !== pomNo.value) { // if was in Short Time Mode (return to Default)
+            else if (mode === 2 && numOfPomodoros !== 4) { // if was in Short Time Mode (return to Default)
                 numOfPomodoros++;
                 mode = 1;
                 countdown.innerHTML = formatTime(defaultTime);
@@ -151,7 +151,7 @@ function startTimer() {
                 startButton.style.display = "block";
                 stopButton.style.display = "none";
             }
-            else if (mode === 1 && numOfPomodoros === (pomNo.value - 1)) { // if was in Pomodoro Mode (go to Long)
+            else if (mode === 1 && numOfPomodoros === 3) { // if was in Pomodoro Mode (go to Long)
                 numOfPomodoros++;
                 mode = 3;
                 countdown.innerHTML = formatTime(longTime);

diff --git a/src/scripts/main.ts b/src/scripts/main.ts
@@ -161,7 +161,7 @@ function startTimer() {
       currentTime = -1;
       playSoundTimer();
       clearInterval(timer);
-      if (mode === 1 && numOfPomodoros !== (pomNo.value - 1)) { // if was in Pomodoro Mode (go to Short)
+      if (mode === 1 && numOfPomodoros !== 3) { // if was in Pomodoro Mode (go to Short)
         mode = 2;
         countdown.innerHTML = formatTime(shortTime);
         document.title = formatTime(shortTime) + " - PomodoPro";
@@ -171,7 +171,7 @@ function startTimer() {
         shortBreak.style.color = "black";
         startButton.style.display = "block";
         stopButton.style.display = "none";
-      } else if (mode === 2 && numOfPomodoros !== pomNo.value) { // if was in Short Time Mode (return to Default)
+      } else if (mode === 2 && numOfPomodoros !== 4) { // if was in Short Time Mode (return to Default)
         numOfPomodoros++
         mode = 1;
         countdown.innerHTML = formatTime(defaultTime);
@@ -182,7 +182,7 @@ function startTimer() {
         shortBreak.style.color = "white";
         startButton.style.display = "block";
         stopButton.style.display = "none";
-      } else if (mode === 1 && numOfPomodoros === (pomNo.value - 1)) { // if was in Pomodoro Mode (go to Long)
+      } else if (mode === 1 && numOfPomodoros === 3) { // if was in Pomodoro Mode (go to Long)
         numOfPomodoros++
         mode = 3;
         countdown.innerHTML = formatTime(longTime);