Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper engine config #144

Merged
merged 1 commit into from
Jan 11, 2024
Merged

proper engine config #144

merged 1 commit into from
Jan 11, 2024

Conversation

anthdm
Copy link
Owner

@anthdm anthdm commented Jan 9, 2024

Nice builder pattern with default config. I think nil is powerful and handy, but not for configuration.

@anthdm anthdm requested a review from perbu January 9, 2024 19:57
@anthdm anthdm merged commit 4b54786 into master Jan 11, 2024
2 checks passed
@anthdm anthdm deleted the engine-config branch January 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants