Support io direct read cross blocks #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
force-pushed
the
cross_block_read
branch
from
799babe to
5ccf4a8
Compare
jiaweizone
reviewed
Oct 11, 2024
src/data_cell/flatten_datacell.h
Outdated
| GetCodesById(uint64_t id, bool& need_release) const override; | ||
|
|
||
| bool | ||
| GetCodesById(uint8_t* codes, uint64_t id) const override; |
There was a problem hiding this comment.
Adjust the params sequence: Input before output
Comment on lines
157
to
158
| if (check_valid_offset(size + offset)) { | ||
| if (check_in_one_block(offset, size + offset)) { |
There was a problem hiding this comment.
unify name style: checkValidOffset / checkInOneBlock (like memory_io.h:112)
There was a problem hiding this comment.
we use under line style for private function. the memory_io.h will be fixed by other pull request
LHT129
force-pushed
the
cross_block_read
branch
3 times, most recently
from
aa9bf1d to
4890963
Compare
Signed-off-by: LHT129 <[email protected]>
LHT129
force-pushed
the
cross_block_read
branch
from
4890963 to
f3bc4c3
Compare
jiaweizone
approved these changes
Oct 14, 2024
| } | ||
|
|
||
| template <typename QuantTmpl, typename IOTmpl> | ||
| const uint8_t* | ||
| FlattenDataCell<QuantTmpl, IOTmpl>::GetCodesById(uint64_t id) const { | ||
| return io_->Read(code_size_, id * code_size_); | ||
| FlattenDataCell<QuantTmpl, IOTmpl>::GetCodesById(uint64_t id, bool& need_release) const { |
There was a problem hiding this comment.
add TODO to simplify memory management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #40