Add io component #59
Merged
Add io component #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inabao
reviewed
Oct 11, 2024
src/io/basic_io_test.h
Outdated
| std::vector<uint64_t> max_lengths = {2, 20, 37, 64, 128, 260, 999, 4097}; | ||
| srandom(time(nullptr)); | ||
| std::string dirname = "/tmp/random_TestSerializeAndDeserialize_" + std::to_string(random()); | ||
| std::filesystem::create_directory(dirname); |
There was a problem hiding this comment.
use fixtures::temp_dir to create tmp directory for testing
src/io/memory_block_io.h
Outdated
|
|
||
| private: | ||
| [[nodiscard]] inline bool | ||
| checkValidOffset(uint64_t size) const { |
There was a problem hiding this comment.
checkValidOffset to check_valid_offset
src/io/memory_block_io.h
Outdated
| checkAndRealloc(uint64_t size); | ||
|
|
||
| [[nodiscard]] inline const uint8_t* | ||
| getDataPtr(uint64_t offset) const { |
src/io/memory_block_io.h
Outdated
| } | ||
|
|
||
| inline void | ||
| checkAndRealloc(uint64_t size); |
src/io/memory_block_io.h
Outdated
| } | ||
|
|
||
| [[nodiscard]] inline bool | ||
| checkInOneBlock(uint64_t off1, uint64_t off2) const { |
|
|
||
| std::vector<uint8_t*> blocks_{}; | ||
|
|
||
| Allocator* const allocator_{nullptr}; |
There was a problem hiding this comment.
Allocator* const to const Allocator*
There was a problem hiding this comment.
I think T* const is better
| @@ -68,7 +82,7 @@ class MemoryIO : public BasicIO<MemoryIO> { | |||
| } | |||
|
|
|||
| private: | |||
| Allocator* allocator_{nullptr}; | |||
| Allocator* const allocator_{nullptr}; | |||
There was a problem hiding this comment.
I think T* const is better
- implement memory block io - io test for read&write - io test for serialize&deserialize - add common index param - add datatype Signed-off-by: LHT129 <[email protected]>
inabao
approved these changes
Oct 11, 2024
ShawnShawnYou
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #40