update the example of custom memory allocator #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxyucs
added
the
kind/improvement
wxyucs
force-pushed
the
update-example
branch
from
518ea65 to
8d3c421
Compare
jiaweizone
reviewed
Dec 24, 2024
| return; | ||
| vsag::Options::Instance().logger()->Debug("deallocate " + std::to_string(sizes_[p]) + | ||
| " bytes."); | ||
| sizes_.erase(p); |
There was a problem hiding this comment.
minor: reduce dup find cost
auto iter = sizes_.find(p);
if (iter == sizes_.end() {
return;
}
sizes_.erase(iter);
wxyucs
force-pushed
the
update-example
branch
from
8d3c421 to
e4c8de1
Compare
Signed-off-by: wxy407827 <[email protected]>
wxyucs
force-pushed
the
update-example
branch
from
e4c8de1 to
e803026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.