Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(src): reinit vsag by explicitly calling init() #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Coien-rr
Copy link
Contributor

@Coien-rr Coien-rr commented Nov 4, 2024

related: #108

if we use VSAG by static lib, we need explicitly call vsag::init()
but it will reinit VSAG, since init() has been called to initializing _init. https://github.com/alipay/vsag/blob/185eccffd8b3db6e77c3c24d378c40bc15243d36/src/vsag.cpp#L61
although reinitializing VSAG does not cause bugs yet.
But this code is not elegant, on the other hand, the init log will repeat twice in debug mode

Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants