add check for number of elements in diskann #104
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinjiabao.jjb <[email protected]>
inabao
added
the
kind/improvement
wxyucs
reviewed
Oct 31, 2024
src/index/diskann.cpp
Outdated
Comment on lines
229
to
230
| CHECK_ARGUMENT(data_num >= 2, | ||
| fmt::format("base.num_elements({}) must be greater than 2", data_num)); |
There was a problem hiding this comment.
is it related to any bug or issue?
There was a problem hiding this comment.
It is not relate any bugs. We have constrained this matter in functests, but we haven't done any checks in the code, which is not acceptable.
There was a problem hiding this comment.
should we add some unit tests or func tests to cover this new behavior?
There was a problem hiding this comment.
I have added the related unit test.
There was a problem hiding this comment.
@inabao I saw that the minimum number of elements is changed to 1. What is the consideration?
There was a problem hiding this comment.
>1 == >=2, so we should keep the minimum number of elements equal to 2 and greater than 1
Signed-off-by: jinjiabao.jjb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.