Added Write method to rest ResponseWriter interface. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added this function to satisfy the interface of http.ResponseWriter, allowing rest.ResponseWriter to be used interchangably with http.ResponseWriter.
|
I believe this is against Go principles. Why not just using type assertion ? |
|
I'm not too sure about it being against go principles. Go is all for satisfying interfaces. You see it a lot in the standard packages, especially the Also, I doubt type assertion will help with #192. |
|
Hi @ant0ine, any update on this? |
|
Duplicate of this one: #189 Closing for the same reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192
I've added this function to satisfy the interface of http.ResponseWriter,
allowing rest.ResponseWriter to be used interchangably with
http.ResponseWriter.