feat(FloatingPanel): support position attribute #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6829 +/- ##
==========================================
- Coverage 92.70% 92.67% -0.03%
==========================================
Files 335 335
Lines 7199 7213 +14
Branches 1793 1814 +21
==========================================
+ Hits 6674 6685 +11
- Misses 490 492 +2
- Partials 35 36 +1 ☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Feb 18, 2025
| @@ -25,6 +26,7 @@ export type FloatingPanelProps = { | |||
| children: ReactNode | |||
| onHeightChange?: (height: number, animating: boolean) => void | |||
| handleDraggingOfContent?: boolean | |||
| position?: 'bottom' | 'top' | |||
zombieJ
reviewed
Feb 18, 2025
| <div className={`${classPrefix}-header`} ref={headerRef}> | ||
| <div className={`${classPrefix}-bar`} /> | ||
| </div> | ||
| {position === 'bottom' && ( |
There was a problem hiding this comment.
申明一个 headerNode 变量，然后条件填进来，不要重复写定义代码~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现#6827