Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pick shouldn't strictly equal #6541

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: pick shouldn't strictly equal #6541

wants to merge 1 commit into from

Conversation

Yueyanc
Copy link

@Yueyanc Yueyanc commented Feb 5, 2024

afc163
afc163 reviewed Feb 5, 2024
View reviewed changes
src/components/picker-view/wheel.tsx
@@ -59,7 +59,7 @@ export const Wheel = memo<Props>(
useIsomorphicLayoutEffect(() => {
if (draggingRef.current) return
if (value === null) return
const targetIndex = column.findIndex(item => item.value === value)
const targetIndex = column.findIndex(item => item.value == value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

永远都不应该使用 ==

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那或者将value默认转换成number呢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yueyanc @afc163