-
Notifications
You must be signed in to change notification settings - Fork 135
fix: Adapt new visualizer version #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideAdapts the codebase to the updated visualization interface by removing unsupported keyword arguments from show() calls, bumping the tools-visualization-interface dependency to 0.10.0, and aligning the Visualizer.show method with the new backend API. Sequence diagram for plotting workflow with updated show() callssequenceDiagram
participant User
participant Mapdl
participant MapdlPlotter
participant Visualizer
User->>Mapdl: Call plot method (e.g., kplot, lplot, aplot, nplot, eplot)
Mapdl->>MapdlPlotter: plot(..., **kwargs)
MapdlPlotter->>Visualizer: show(...)
Visualizer->>Visualizer: show(window_size, savefig, return_plotter)
Note right of Visualizer: No extra **kwargs passed to show()
Visualizer-->>User: Rendered plot or plotter object
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
for more information, see https://pre-commit.ci
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Adapt plotting methods to the updated visualization interface by removing deprecated keyword arguments from show() calls and upgrade the ansys-tools-visualization-interface dependency to 0.10.0.
Enhancements:
Build: