-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Datamodel cb signature for various events #3624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Jan 8, 2025
mkundu1
commented
Jan 8, 2025
mkundu1
commented
Jan 8, 2025
seanpearsonuk
approved these changes
Jan 9, 2025
hpohekar
approved these changes
Jan 9, 2025
mkundu1
force-pushed
the
feat/datamodel-cbs
branch
from
January 9, 2025 14:37
cde2f3f
to
c7409e5
Compare
mkundu1
changed the title
feat: Datamodel cb for add_on_child_created - for review
feat: Datamodel cb signature for various events
Jan 9, 2025
This will be accompanied with a Fluent side change. |
mkundu1
force-pushed
the
feat/datamodel-cbs
branch
from
January 9, 2025 23:04
c7409e5
to
9cca9e7
Compare
mkundu1
force-pushed
the
feat/datamodel-cbs
branch
from
January 10, 2025 16:04
f981f22
to
ab3c83b
Compare
mkundu1
added a commit
that referenced
this pull request
Jan 10, 2025
* feat: Datamodel cb for add_on_child_created * feat: datamodel cbs for other events * feat: type hint * feat: add_on_changed * feat: type hint * feat: Registration method signature is changed * test: fix
mkundu1
added a commit
that referenced
this pull request
Jan 11, 2025
* feat: Datamodel cb signature for various events (#3624) * feat: Datamodel cb for add_on_child_created * feat: datamodel cbs for other events * feat: type hint * feat: add_on_changed * feat: type hint * feat: Registration method signature is changed * test: fix * build: Bump version 0.28.2 * fix: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in comment.