Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Datamodel cb signature for various events #3624

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jan 8, 2025

Details in comment.

@mkundu1 mkundu1 force-pushed the feat/datamodel-cbs branch from cde2f3f to c7409e5 Compare January 9, 2025 14:37
@mkundu1 mkundu1 marked this pull request as ready for review January 9, 2025 14:37
@mkundu1 mkundu1 changed the title feat: Datamodel cb for add_on_child_created - for review feat: Datamodel cb signature for various events Jan 9, 2025
@mkundu1
Copy link
Contributor Author

mkundu1 commented Jan 9, 2025

This will be accompanied with a Fluent side change.

@mkundu1 mkundu1 force-pushed the feat/datamodel-cbs branch from c7409e5 to 9cca9e7 Compare January 9, 2025 23:04
@mkundu1 mkundu1 force-pushed the feat/datamodel-cbs branch from f981f22 to ab3c83b Compare January 10, 2025 16:04
@mkundu1 mkundu1 merged commit f73e03b into main Jan 10, 2025
30 checks passed
@mkundu1 mkundu1 deleted the feat/datamodel-cbs branch January 10, 2025 18:31
mkundu1 added a commit that referenced this pull request Jan 10, 2025
* feat: Datamodel cb for add_on_child_created

* feat: datamodel cbs for other events

* feat: type hint

* feat: add_on_changed

* feat: type hint

* feat: Registration method signature is changed

* test: fix
mkundu1 added a commit that referenced this pull request Jan 11, 2025
* feat: Datamodel cb signature for various events (#3624)

* feat: Datamodel cb for add_on_child_created

* feat: datamodel cbs for other events

* feat: type hint

* feat: add_on_changed

* feat: type hint

* feat: Registration method signature is changed

* test: fix

* build: Bump version 0.28.2

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants