Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for USERD case file reader #502

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

randallfrank
Copy link
Collaborator

Read the xml crash dataset using libuserd.

Read the xml crash dataset using libuserd.
@kecolburn
Copy link
Collaborator

I did not see immediately that this forced the use of the VKI reader. I assume that the libuserd doesn't know about the EnSight Case format, and those only finds this VKI reader for the query on the .case file. From an user perspective, are they fooled a bit by thinking this is an EnSight Case Gold reader, while it is actually a VKI reader (which may / may not work completely).

@randallfrank
Copy link
Collaborator Author

I did not see immediately that this forced the use of the VKI reader. I assume that the libuserd doesn't know about the EnSight Case format, and those only finds this VKI reader for the query on the .case file. From an user perspective, are they fooled a bit by thinking this is an EnSight Case Gold reader, while it is actually a VKI reader (which may / may not work completely).

@kecolburn exactly. The VKI EnSight case gold reader is named "USERD EnSight Case" and is the only userd reader that can reader .case files. So:

readers = libuserd.query_format("example.case")
assert len(readers) == 1
assert readers[0].name == "USERD EnSight Case"

verifies that there is one and only reader .case file reader and that the name of the reader matches the VKI reader name. From a user's perspective, we have a reader than can read (a subset of) the casefile format. In the future, we can replace the VKI implementation with something else that might be more capable and we would replace the implementation of that reader, but keep the name.

My approach for finding the file is broken for docker however, so another commit is inbound.

Use an EnSight dataset from the ansys example-data repo.
Add rank count specification to Initialize().
Fix a test case for function value instead of function.
kecolburn
kecolburn previously approved these changes Jan 4, 2025
remove extra quote
@mariostieriansys mariostieriansys merged commit 6f5d54a into main Jan 6, 2025
25 checks passed
@mariostieriansys mariostieriansys deleted the fix/add_case_reader_test branch January 6, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants