Fix/improve feedback #394
Merged
Fix/improve feedback #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old code Remove unused textures Include a file on disk to send status info Allow kit to use local wheel version (for dev work).
- make kit aware of locally installed ansys.pyensight.core and use it when possible - improve status feedback.
Change the documentation on how a developer might use the kits.
Kit toml files track the pyensight version.
mariostieriansys
previously approved these changes
Jul 29, 2024
Move from 0.9.0.dev0 to 0.9.0-dev0
mariostieriansys
approved these changes
Jul 29, 2024
|
The "Time scaling factor" dialog box is too live. Any types in that dialog cause an upload. This should not cause an upload/push. User should be able to type/correct/change that without an upload. (only upload push does the push). Should toggling on/off the 'normalize' cause an upload? (I would expect 'no', but I am getting a push). |
mariostieriansys
pushed a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.