Introduce Omniverse kits #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ansys.geometry.serviceand ansys.geometry.seviceui kits to the wheel. Note: these will also be redistributed directly via an omniverse branch.
There was a problem hiding this comment.
About this branch, I just need a change in the project toml to not kick the coverage against it.
Anyway, I am not sure if this is the best place to put the folder, given that we cannot use another tool apart from flit, to follow the pyansys guidance.
However, I have an idea. I sent you the info in chat
The OV extensions are now in the repo root and inside of the wheel. The core pyensight (ensight.utils.omniverse) API is used to launch via the kit interface in all cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 93.86% 96.36% +2.49%
==========================================
Files 18 17 -1
Lines 2690 2611 -79
Branches 321 302 -19
==========================================
- Hits 2525 2516 -9
+ Misses 124 51 -73
- Partials 41 44 +3 ☔ View full report in Codecov by Sentry. |
Code docs include external links.
Rewrite docs for the OV link.
mariostieriansys
previously approved these changes
Jul 9, 2024
Removed unused code.
mariostieriansys
previously approved these changes
Jul 9, 2024
Switch tomllib use to 'loads()' to avoid a backward compatibility issue. Add full temporal support to the kit and pyensight APIs.
The DSG close call is actually called shutdown.
mariostieriansys
approved these changes
Jul 10, 2024
mariostieriansys
added a commit
that referenced
this pull request
Jul 10, 2024
Co-authored-by: Mario Ostieri <[email protected]> Co-authored-by: Mario Ostieri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ansys.geometry.serviceand ansys.geometry.seviceui kits to the wheel. Note: these will also be redistributed directly via an omniverse branch.