Fix/session str badhostname #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hostname should be output as a string so that str(session) returns a valid Python command.
The raw session ctor is now tested.
The 'Session' ctor needs to be accessible.
The Session module is implicitly used.
mariostieriansys
previously approved these changes
Mar 12, 2024
|
thanks @randallfrank, I was talking with Jerfried of exactly this issue we found |
mariostieriansys
approved these changes
Mar 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
- Coverage 81.35% 81.32% -0.04%
==========================================
Files 17 17
Lines 3331 3331
Branches 688 656 -32
==========================================
- Hits 2710 2709 -1
- Misses 348 349 +1
Partials 273 273 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the str(Session) call. html_hostname keyword output generated invalid Python code.