-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostieri/particle traces #338
Conversation
@randallfrank @kecolburn at the moment this PR is in draft mode so that we can discuss about the API before merging it. The way I have designed it is that the user sees exposed only one function, create_particle_trace. I have used Randy suggestion of creating subclasses of ens_emitterobj, which simplify the handling of the creation of the objects. However these classes really work only in EnSight, i.e. if in ensight you call ensight.utils.parts._EnSEmitterPoint(ensight, point1=[1,1,1]) will actually create a valid emitter. Technicalities apart, the PR isn't complete for merge:
Any suggestion would be very welcome |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 79.92% 75.40% -4.52%
==========================================
Files 18 18
Lines 2570 2769 +199
Branches 454 495 +41
==========================================
+ Hits 2054 2088 +34
- Misses 357 522 +165
Partials 159 159 ☔ View full report in Codecov by Sentry. |
No description provided.