fix: BOUNDARY_PRESCRIBED_MOTION_*_ID option and CONTROL_MPP_DECOMPOSITION_TRANSFORMATION (Issue #696) #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Handles optional card 2 which is activated by certain types. Ultimately a single dataframe is created. The keyword is written correctly as well. However due to the single dataframe comment lines inbetween get lost. (Issue #696)
RaphaelHeiniger
added
bug
2 tasks
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
github-actions
bot
added
the
documentation
koubaa
approved these changes
Feb 7, 2025
|
@RaphaelHeiniger I think the limitation about losing comments inside dataframes is not unique to this keyword. We have this problem for any keywords that we handle using dataframes. If we try to retain comments between rows, the I/O gets much slower. |
RaphaelHeiniger
deleted the
fix-control-mpp-decomposition-transformation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
BOUNDARY_PRESCRIBED_MOTION_*_ID fix required an new additional-card. I could have reused the CONTACT_ID as the new one has the exact same behavior but for readability I named the new one ID_HEADING.
CONTROL_MPP_DECOMPOSITION_TRANSFORMATION the cards will end up in a single dataframe means during reading the comments between lines will get lost. However functionality is here. @koubaa please let me know if you know a better solution.