feat(plotter): enable plots of mesh scopings #2377
Open
+392
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2377 +/- ##
===========================================
- Coverage 84.07% 47.38% -36.69%
===========================================
Files 91 91
Lines 10540 10573 +33
===========================================
- Hits 8861 5010 -3851
- Misses 1679 5563 +3884 |
|
The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2377. Please allow some time for the documentation to be deployed. |
PProfizi
commented
Jun 18, 2025
PProfizi
commented
Jun 18, 2025
PProfizi
commented
Jun 18, 2025
PProfizi
commented
Jun 18, 2025
rafacanton
reviewed
Jun 19, 2025
| ---------- | ||
| mesh: | ||
| Mesh or meshes to use to translate the scopings into mesh entities. | ||
| Associates each scoping to a mesh using labels if ``mesh`` is a collection of meshes. |
There was a problem hiding this comment.
Suggested change
| Associates each scoping to a mesh using labels if ``mesh`` is a collection of meshes. | |
| Associates each scoping to a mesh using labels if ``mesh`` is a MeshesContainer. |
There was a problem hiding this comment.
@rafacanton thanks this made me notice I actually forgot to implement that behavior
|
PS: codecoverage reporting is broken. Here coverage on new lines is 100%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1245
TODO: