feat: Example 8 - calculate RMS, dBSPL and dBA levels #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanredon
requested review from
a-bouth,
anssmolla,
anscquesson,
anshlachamb and
ansaminard
as code owners
github-actions
bot
added
documentation
anssmolla
reviewed
Mar 20, 2025
examples/008_calculate_levels.py
Outdated
|
|
||
| # %% | ||
| # In a loop, for each sound, create a :class:`.OverallLevel` object, set its signals, | ||
| # get and the overall RMS, dBSPL and dBA levels, then Write the results into the first .csv file. |
There was a problem hiding this comment.
@milanredon there is a missing verb here:
"get and XXX the overall RMS"
my guess XXX = display? print?
examples/008_calculate_levels.py
Outdated
|
|
||
| # %% | ||
| # In a loop, for each sound, create a :class:`.OverallLevel` object, set its signals, | ||
| # get and the overall RMS, dBSPL and dBA levels, then Write the results into the one .csv file per sound. |
There was a problem hiding this comment.
@milanredon there is a missing verb here:
"get and XXX the overall RMS"
my guess: XXX = plot?
There was a problem hiding this comment.
@milanredon it is probably "[...] dBSPL and dBA vs time, [...]"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 79 81 +2
Lines 4648 4974 +326
==========================================
+ Hits 4648 4974 +326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a-bouth
reviewed
Mar 20, 2025
ansaminard
requested changes
Mar 21, 2025
…s/pyansys-sound into feat/example-with-dB-levels
for more information, see https://pre-commit.ci
…figure in the doc + some minor improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example to calculate overall levels, levels versus time and to write the results in csv files.