-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: save sound composer project #248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 81 81
Lines 4867 4968 +101
==========================================
+ Hits 4867 4968 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/tests_sound_composer/test_sound_composer_sound_composer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but don't forget to add plots to the general description of your PR
…ant with content test
@a-bouth There is no plot to add |
Added the possibility to save a sound composer project (.scn file) in class
SoundComposer
To allow this, it was necessary to modify class
Filter
such that it now stores the FRFAlso,
SourceControlTime
and BBN and harmo sources were modified such that the "displayed string(s)" in Sound Composer project files can be stored and retrieved in load/save operations.