Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save sound composer project #248

Merged
merged 25 commits into from
Mar 13, 2025
Merged

feat: save sound composer project #248

merged 25 commits into from
Mar 13, 2025

Conversation

ansaminard
Copy link
Collaborator

@ansaminard ansaminard commented Mar 10, 2025

Added the possibility to save a sound composer project (.scn file) in class SoundComposer
To allow this, it was necessary to modify class Filter such that it now stores the FRF

Also, SourceControlTime and BBN and harmo sources were modified such that the "displayed string(s)" in Sound Composer project files can be stored and retrieved in load/save operations.

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Mar 10, 2025
@ansaminard ansaminard marked this pull request as ready for review March 11, 2025 11:58
@ansaminard ansaminard enabled auto-merge (squash) March 11, 2025 11:58
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (437145b) to head (6c31804).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #248    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           81        81            
  Lines         4867      4968   +101     
==========================================
+ Hits          4867      4968   +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

anshlachamb
anshlachamb previously approved these changes Mar 13, 2025
a-bouth
a-bouth previously approved these changes Mar 13, 2025
Copy link
Collaborator

@a-bouth a-bouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but don't forget to add plots to the general description of your PR

@ansaminard ansaminard dismissed stale reviews from a-bouth and anshlachamb via 0f034a0 March 13, 2025 13:55
@ansaminard
Copy link
Collaborator Author

Looks good to me but don't forget to add plots to the general description of your PR

@a-bouth There is no plot to add

@a-bouth a-bouth self-requested a review March 13, 2025 15:48
@ansaminard ansaminard merged commit 5cde28e into main Mar 13, 2025
31 checks passed
@ansaminard ansaminard deleted the feat/sound-composer-save branch March 13, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants