feat: Tonality IS/TS 20065 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansaminard
requested review from
a-bouth,
anssmolla,
anscquesson and
anshlachamb
as code owners
github-actions
bot
added
documentation
anshlachamb
reviewed
Feb 26, 2025
a-bouth
reviewed
Feb 26, 2025
a-bouth
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 79 80 +1
Lines 4648 4758 +110
==========================================
+ Hits 4648 4758 +110 ☔ View full report in Codecov by Sentry. |
anshlachamb
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper class, test class, and doc update for ISO/TS 20065 tonality
Also updated/added consistency in DIN 45681 and removed default spectrum/tone index value for the sake of consistency with other indicators