-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace mutable empty list by None in Filter class constructor #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansaminard
requested review from
a-bouth,
anssmolla,
anscquesson and
anshlachamb
as code owners
January 20, 2025 16:25
Closed
2 tasks
…com/ansys/pyansys-sound into bug/filter-constructor-coefficients
…com/ansys/pyansys-sound into bug/filter-constructor-coefficients
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 75 75
Lines 4367 4367
=========================================
Hits 4367 4367 ☔ View full report in Codecov by Sentry. |
anshlachamb
approved these changes
Jan 23, 2025
a-bouth
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In class
Filter
, use None as default value for A/B coefficient lists to avoid issues related to the mutable nature of listsAlso:
== []
tests withlen() == 0
tests to avoid not-the-same-shape errors when coefficients are passed as numpy arrays (instead of lists)