feat: Tonality ECMA418-2 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bouth
requested review from
anssmolla,
anscquesson,
anshlachamb and
ansaminard
as code owners
|
Important note (@ansaminard ) the outputs tonality over time and tone frequency over time might have slightly different time scales (same behaviour as in SAS), as a consequence :
|
ansaminard
reviewed
Jan 16, 2025
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 74 +1
Lines 4236 4306 +70
=========================================
+ Hits 4236 4306 +70 ☔ View full report in Codecov by Sentry. |
ansaminard
previously approved these changes
Jan 16, 2025
anshlachamb
reviewed
Jan 17, 2025
ansaminard
reviewed
Jan 20, 2025
ansaminard
previously approved these changes
Jan 20, 2025
anshlachamb
previously approved these changes
Jan 20, 2025
It's already updated @ansaminard |
ansaminard
approved these changes
Jan 20, 2025
anshlachamb
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added class
TonalityECMA418_2+ Associated tests