Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: overall level and level over time #201

Merged
merged 14 commits into from
Jan 13, 2025
Merged

feat: overall level and level over time #201

merged 14 commits into from
Jan 13, 2025

Conversation

ansaminard
Copy link
Collaborator

Helper and test classes for overall level and level over time

@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Jan 8, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (951ba4c) to head (8c3e965).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main      #201    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           64        68     +4     
  Lines         3511      3716   +205     
==========================================
+ Hits          3511      3716   +205

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansaminard ansaminard changed the title feat: oveall level and level over time feat: overall level and level over time Jan 9, 2025
@ansaminard ansaminard marked this pull request as ready for review January 9, 2025 10:15
@ansaminard ansaminard enabled auto-merge (squash) January 9, 2025 10:16
mattbennett72
mattbennett72 reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mattbennett72 mattbennett72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps these are the wrong tense?

src/ansys/sound/core/standard_levels/level_over_time.py Outdated Show resolved Hide resolved
src/ansys/sound/core/standard_levels/overall_level.py Outdated Show resolved Hide resolved
a-bouth
a-bouth previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@a-bouth a-bouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ansaminard I'm approving the PR but two general comments :

  • Please add screenshots of the plots in the PR description next time
  • I'm not going to argue forever but I'm not in favor of using a dictionnary for the differents enums, I would at least have prefered a subclass/enum within ansys.sound.core

@ansaminard ansaminard merged commit 10eaa91 into main Jan 13, 2025
29 checks passed
@ansaminard ansaminard deleted the feat/overal-level branch January 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbennett72 mattbennett72 mattbennett72 left review comments

@anshlachamb anshlachamb anshlachamb approved these changes

@a-bouth a-bouth a-bouth approved these changes

@anssmolla anssmolla Awaiting requested review from anssmolla anssmolla is a code owner

@anscquesson anscquesson Awaiting requested review from anscquesson anscquesson is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ansaminard @a-bouth @mattbennett72 @anshlachamb @pyansys-ci-bot