feat: improve example files handling in examples scripts #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshlachamb
requested review from
a-bouth,
anssmolla,
anscquesson and
ansaminard
as code owners
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
…ipts' of https://github.com/ansys/pyansys-sound into feat/182-improve-example-files-handling-in-examples-scripts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 3511 3511
=========================================
Hits 3511 3511 ☔ View full report in Codecov by Sentry. |
a-bouth
reviewed
Dec 20, 2024
a-bouth
reviewed
Dec 20, 2024
for more information, see https://pre-commit.ci
…ipts' of https://github.com/ansys/pyansys-sound into feat/182-improve-example-files-handling-in-examples-scripts
a-bouth
previously approved these changes
Dec 20, 2024
|
Example 6 broken. I set this comment to block the PR |
…ipts' of https://github.com/ansys/pyansys-sound into feat/182-improve-example-files-handling-in-examples-scripts
for more information, see https://pre-commit.ci
… error in example 6, for testing this commit
…ipts' of https://github.com/ansys/pyansys-sound into feat/182-improve-example-files-handling-in-examples-scripts
anssmolla
previously approved these changes
Dec 20, 2024
a-bouth
approved these changes
Dec 23, 2024
anssmolla
approved these changes
Dec 23, 2024
a-bouth
deleted the
feat/182-improve-example-files-handling-in-examples-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All example files are now uploaded on the server side and the paths are uploaded accordingly, the path will always be the correct one either in local or docker configuration
Exception made for flute_psd.txt this file is needed only locally as we're using native python functions to read it and not DPF Operators
side modification: "abort_on_example_error": True, added in conf.py to ensure that the failure of one example generation leads to the general failure of the PR