Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sound Composer track #191

Merged
merged 10 commits into from
Dec 19, 2024
Merged

feat: Sound Composer track #191

merged 10 commits into from
Dec 19, 2024

Conversation

ansaminard
Copy link
Collaborator

@ansaminard ansaminard commented Dec 13, 2024 •
edited by anssmolla
Loading

Helper and test classes for sound composer track
Also modified source control attribute name in source BBN with 2 params

@ansaminard ansaminard enabled auto-merge (squash) December 13, 2024 17:18
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New features or code improvements labels Dec 13, 2024
mattbennett72
mattbennett72 reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@mattbennett72 mattbennett72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small omission

src/ansys/sound/core/sound_composer/track.py Outdated Show resolved Hide resolved
@ansaminard ansaminard disabled auto-merge December 18, 2024 07:12
@ansaminard ansaminard marked this pull request as draft December 18, 2024 07:12
@ansaminard ansaminard marked this pull request as ready for review December 19, 2024 06:43
@ansaminard ansaminard enabled auto-merge (squash) December 19, 2024 06:43
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a089077) to head (35f3e38).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main      #191    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           63        64     +1     
  Lines         3337      3511   +174     
==========================================
+ Hits          3337      3511   +174

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-bouth a-bouth self-requested a review December 19, 2024 11:14
a-bouth
a-bouth approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@a-bouth a-bouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ansaminard ansaminard merged commit 5133c93 into main Dec 19, 2024
31 checks passed
@ansaminard ansaminard deleted the feat/sound-composer/track branch December 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbennett72 mattbennett72 mattbennett72 left review comments

@anshlachamb anshlachamb anshlachamb approved these changes

@a-bouth a-bouth a-bouth approved these changes

@anssmolla anssmolla Awaiting requested review from anssmolla anssmolla is a code owner

@anscquesson anscquesson Awaiting requested review from anscquesson anscquesson is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ansaminard @a-bouth @mattbennett72 @anshlachamb @pyansys-ci-bot