Skip to content

Edit documentation build instructions #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

greschd
Copy link
Member

@greschd greschd commented Feb 17, 2025

  • Distinguish more clearly between doc builds using "default" launch configuration, and docker compose based builds.
  • Expand the instructions for environment variables needed when using Docker Compose.
  • Don't set the ANSYS_DPF_ACCEPT_LA environment variable in create_doc_windows.ps1, since the user is meant to set this manually.
  • Switch to using the latest tag for the DPF Composites container in the documentation build.
  • Remove the outdated link to the "launching ACP" section.

Closes #743

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (a78a5ab) to head (7670bb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         109      109           
  Lines        5700     5700           
  Branches      323      323           
=======================================
  Hits         5414     5414           
  Misses        285      285           
  Partials        1        1           
Flag Coverage Δ
direct-launch 91.57% <ø> (ø)
minimum-deps 93.14% <ø> (ø)
python-3.10 94.21% <ø> (ø)
python-3.11 94.14% <ø> (ø)
python-3.12 94.33% <ø> (ø)
server-2024R2 90.77% <ø> (ø)
server-2025R1 94.14% <ø> (ø)
server-2025R2 94.14% <ø> (ø)
server-latest 94.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greschd greschd enabled auto-merge (squash) March 20, 2025 07:15
@greschd greschd merged commit 2f29ca2 into main Mar 20, 2025
32 checks passed
@greschd greschd deleted the docs/update_doc_build_instructions branch March 20, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to Launching ACP
2 participants