Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable 'price' on 'ModelElementalData' #721

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix: disable 'price' on 'ModelElementalData' #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c254e
Fix: disable 'price' on 'ModelElementalData'
greschd Nov 28, 2024
73cef38
Fix tests
greschd Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/modeling_features/031-imported-solid-model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
from ansys.acp.core import ElementTechnology, LayupMappingRosetteSelectionMethod, launch_acp
from ansys.acp.core.extras import ExampleKeys, get_example_file

# sphinx_gallery_thumbnail_number = 4
# sphinx_gallery_thumbnail_number = 5


# %%
Expand Down Expand Up @@ -125,6 +125,12 @@
model.update()
model.solid_mesh.to_pyvista().plot(show_edges=True)

# %%
# Show the mass of the solid model elements
mass_data = model.elemental_data.mass
assert mass_data is not None
mass_data.get_pyvista_mesh(mesh=model.solid_mesh).plot(show_edges=True)

# %%
# Add other mapping objects
imported_solid_model.create_layup_mapping_object(
Expand Down
8 changes: 7 additions & 1 deletion src/ansys/acp/core/_tree_objects/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,13 @@ class ModelElementalData(ElementalData):
thickness: ScalarData[np.float64] | None = None
relative_thickness_correction: ScalarData[np.float64] | None = None
area: ScalarData[np.float64] | None = None
price: ScalarData[np.float64] | None = None
# Retrieving the 'price' can crash the server if the model contains void
# analysis plies (on an imported solid model).
# This is fixed in the backend for 2025R2, but for now we simply comment
# out the property. In this way, the other properties can still be accessed,
# and we can avoid the crash.
# See https://github.com/ansys/pyacp/issues/717
# price: ScalarData[np.float64] | None = None
volume: ScalarData[np.float64] | None = None
mass: ScalarData[np.float64] | None = None
offset: ScalarData[np.float64] | None = None
Expand Down
2 changes: 1 addition & 1 deletion tests/unittests/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def test_elemental_data(minimal_complete_model):
numpy.testing.assert_allclose(data.thickness.values, np.array([1e-4]))
numpy.testing.assert_allclose(data.relative_thickness_correction.values, np.array([1.0]))
numpy.testing.assert_allclose(data.area.values, np.array([9e4]))
numpy.testing.assert_allclose(data.price.values, np.array([0.0]))
# numpy.testing.assert_allclose(data.price.values, np.array([0.0])) # disabled due to issue #717.
numpy.testing.assert_allclose(data.volume.values, np.array([9.0]))
numpy.testing.assert_allclose(data.mass.values, np.array([7.065e-08]))
numpy.testing.assert_allclose(data.offset.values, np.array([5e-5]))
Expand Down
Loading