-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cut off and drop off names consistent #718
Make cut off and drop off names consistent #718
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 109 109
Lines 5695 5695
Branches 322 322
=======================================
Hits 5410 5410
Misses 284 284
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you also check if the code is consistent w.r.t. SnapTo and snap_to? Or is snapto used somewhere?
Co-authored-by: René Roos <[email protected]>
That's a good point, I had forgotten about SnapTo. I now checked, and it appears to be consistent already. |
Rename the "cut off" and "drop off" related features to make them consistent:
Cutoff
->CutOff
cutoff
->cut_off
Dropoff
->DropOff
dropoff
->drop_off
Partly addresses #637.