Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cut off and drop off names consistent #718

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

greschd
Copy link
Member

@greschd greschd commented Nov 28, 2024

Rename the "cut off" and "drop off" related features to make them consistent:

  • Cutoff -> CutOff
  • cutoff -> cut_off
  • Dropoff -> DropOff
  • dropoff -> drop_off

Partly addresses #637.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (49cf253) to head (9e6dcf8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         109      109           
  Lines        5695     5695           
  Branches      322      322           
=======================================
  Hits         5410     5410           
  Misses        284      284           
  Partials        1        1           
Flag Coverage Δ
direct-launch 91.58% <100.00%> (ø)
minimum-deps 93.19% <100.00%> (ø)
python-3.10 94.25% <100.00%> (ø)
python-3.11 94.18% <100.00%> (ø)
python-3.12 94.38% <100.00%> (ø)
server-2024R2 90.81% <100.00%> (ø)
server-2025R1 94.18% <100.00%> (ø)
server-2025R2 94.18% <100.00%> (ø)
server-latest 94.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@roosre roosre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also check if the code is consistent w.r.t. SnapTo and snap_to? Or is snapto used somewhere?

src/ansys/acp/core/_tree_objects/cut_off_selection_rule.py Outdated Show resolved Hide resolved
examples/modeling_features/03-advanced-selection-rules.py Outdated Show resolved Hide resolved
src/ansys/acp/core/_tree_objects/cut_off_selection_rule.py Outdated Show resolved Hide resolved
src/ansys/acp/core/_tree_objects/cut_off_selection_rule.py Outdated Show resolved Hide resolved
src/ansys/acp/core/_tree_objects/cut_off_selection_rule.py Outdated Show resolved Hide resolved
tests/unittests/test_tree_printer.py Show resolved Hide resolved
@greschd
Copy link
Member Author

greschd commented Nov 28, 2024

Did you also check if the code is consistent w.r.t. SnapTo and snap_to? Or is snapto used somewhere?

That's a good point, I had forgotten about SnapTo. I now checked, and it appears to be consistent already.

@greschd greschd enabled auto-merge (squash) November 28, 2024 18:58
@greschd greschd merged commit ca187a5 into main Nov 28, 2024
32 checks passed
@greschd greschd deleted the feat/make_cut_off_and_drop_off_names_consistent branch November 28, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants