Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DimensionType to PhysicalDimension #716

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

greschd
Copy link
Member

@greschd greschd commented Nov 28, 2024

Partially addresses #637.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (ca187a5) to head (06d5b63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         109      109           
  Lines        5695     5695           
  Branches      322      322           
=======================================
  Hits         5410     5410           
  Misses        284      284           
  Partials        1        1           
Flag Coverage Δ
direct-launch 91.58% <100.00%> (ø)
minimum-deps 93.19% <100.00%> (ø)
python-3.10 94.25% <100.00%> (ø)
python-3.11 94.18% <100.00%> (ø)
python-3.12 94.38% <100.00%> (ø)
server-2024R2 90.81% <100.00%> (ø)
server-2025R1 94.18% <100.00%> (ø)
server-2025R2 94.18% <100.00%> (ø)
server-latest 94.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd force-pushed the feat/rename_dimension_type branch from 1ad320b to eabcf6e Compare November 28, 2024 19:04
@greschd greschd enabled auto-merge (squash) November 28, 2024 19:05
@greschd greschd force-pushed the feat/rename_dimension_type branch from eabcf6e to 06d5b63 Compare November 28, 2024 19:27
@greschd greschd linked an issue Nov 28, 2024 that may be closed by this pull request
@greschd greschd merged commit 751e393 into main Nov 28, 2024
32 checks passed
@greschd greschd deleted the feat/rename_dimension_type branch November 28, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review module structure and class names
2 participants