Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkout step to doc deploy job #504

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

Andy-Grigg
Copy link
Contributor

Fix release doc publish failure by adding checkout step to workflow.

I don't think we actually need to checkout this repo, but this is a convenient way of making sure git is setup and authenticated correctly.

Once this is merged I will cherrypick to the release/1.5 branch and try another rc

@Andy-Grigg Andy-Grigg requested a review from da1910 February 26, 2024 17:18
@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Feb 26, 2024
Copy link
Collaborator

@da1910 da1910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, if a bit weird to need to do it even when we don't actually need the code

@Andy-Grigg
Copy link
Contributor Author

Seems reasonable, if a bit weird to need to do it even when we don't actually need the code

If we move to using the PyAnsys publish doc actions we can simplify things again.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (7f50fb0) to head (8891312).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files           7        7           
  Lines         780      780           
=======================================
  Hits          736      736           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andy-Grigg Andy-Grigg added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 8a09bd4 Feb 26, 2024
30 checks passed
Andy-Grigg added a commit that referenced this pull request Feb 26, 2024
@da1910 da1910 deleted the fix/checkout-code-deploy-docs branch February 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants