AAP-28376: lightspeed: move playbook exp/gen away from the LSP server #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
goneri/lightspeed-move-playbook-exp-gen-away-from-the-LSP-server_16261
branch
from
1aa6145 to
c2f168b
Compare
goneri
force-pushed
the
goneri/lightspeed-move-playbook-exp-gen-away-from-the-LSP-server_16261
branch
from
06d91e3 to
28582f1
Compare
goneri
force-pushed
the
goneri/lightspeed-move-playbook-exp-gen-away-from-the-LSP-server_16261
branch
from
a010cf4 to
e73a681
Compare
goneri
force-pushed
the
goneri/lightspeed-move-playbook-exp-gen-away-from-the-LSP-server_16261
branch
from
e73a681 to
9f74293
Compare
goneri
force-pushed
the
goneri/lightspeed-move-playbook-exp-gen-away-from-the-LSP-server_16261
branch
2 times, most recently
from
8df695e to
9176ff9
Compare
It's tricky to get the LSP to send the requests through a HTTP server and we don't want to deal with to different network configuration/stack. In addition, we would like to migrate away from Axios and use Electron's `fetch` which is already configured to use the VS Code proxy configuration.
goneri
changed the title
TamiTakamiya
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's tricky to get the LSP to send the requests through a HTTP server and we don't
want to deal with to different network configuration/stack.
In addition, we would like to migrate away from Axios and use Electron's
fetchwhichis already configured to use the VS Code proxy configuration.